refactor: don't show osc on start when osc_on_seek=yes #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't get it to work :( any ideas? |
|
Are you sure? The behavior now is that it doesn't show OSC on start/next file, only if the OSC already showing it will not explicitly hide it, it'll just rely on hidetimeout then. osc_on_seek.mp4 |
|
Oh sorry you're right, it's my mistake. Works beautifully now! |
|
Okay I just realized why it wasn't working for me. If you have Can ModernZ detect that? |
|
I'll have to think about that one. Since technically with that scenario, it literally seeks back to position. So the event "seeking" is triggered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.