-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to update the app id/secret #92
Conversation
Thanks for the PR! I think this would be better if we could send in an all new $config array so that different apps could use different options (like different versions of Graph for example). You can just Also the method should be named return new static($config); |
Hey @kxgen! Just wanted to check in with you to see if you'd be able to update your PR based on my feedback. If not, l can get in there and make the patch. :) |
Hi @SammyK , sorry to reply you so late, I just follow your guide and change the update method.
right? |
{ | ||
$new_config = array_merge($this->default_config, $config); | ||
|
||
return new static($this->config_handler, $this->url, $config); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be passing in $new_config
as the 3rd arg
Thanks @kxgen! Just change based on my comments and it should be good to pull in. :) |
:) |
Thanks! :) |
usage:
$fb = App::make('SammyK\LaravelFacebookSdk\LaravelFacebookSdk');
$fb->updateAppIdSecret('your_app_id', 'your_app_secret');