Corrections #167
Merged
Corrections #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
babenek
commented
Sep 6, 2024
babenek
commented
Sep 8, 2024
| @@ -22,8 +22,8 @@ Id,FileID,Domain,RepoName,FilePath,LineStart,LineEnd,GroundTruth,WithWords,Value | |||
| 29927,cb05e4cb,GitHub,288eaba8,data/288eaba8/test/cb05e4cb.js,62,62,T,T,17,29,F,F,CharsOnly,,,Secret,3.02,12,F,F,F,Password | |||
| 29932,d2417b18,GitHub,288eaba8,data/288eaba8/test/d2417b18.js,11,11,T,T,17,38,F,F,Any,,,Secret,3.22,21,F,F,F,Password | |||
| 30690,e370d734,GitHub,288eaba8,data/288eaba8/test/e370d734.js,141,141,T,T,24,37,F,F,Any,,,Secret,1.71,13,F,F,F,Password | |||
| 30875,e370d734,GitHub,288eaba8,data/288eaba8/test/e370d734.js,149,149,T,F,64,71,F,F,,,,,0.0,0,F,F,F,Password | |||
| 31159,0d52ab5c,GitHub,288eaba8,data/288eaba8/src/0d52ab5c.yml,74,74,Template,T,26,34,F,F,CharsOnly,,,Secret,2.5,8,F,F,F,Password | |||
| 30875,e370d734,GitHub,288eaba8,data/288eaba8/test/e370d734.js,149,149,T,F,64,74,F,F,,,,,0.0,0,F,F,F,Password | |||
There was a problem hiding this comment.
the end pos of value ist not correctly yet - todo in credsweeper tests
2 tasks
kmnls
approved these changes
Sep 9, 2024
csh519
reviewed
Sep 9, 2024
| 46228,84760b8a,GitHub,fdbe07ac,data/fdbe07ac/test/84760b8a.go,42,42,T,T,7,15,F,F,Any,,,Unknown,2.75,8,F,F,F,Password | ||
| 46228,84760b8a,GitHub,fdbe07ac,data/fdbe07ac/test/84760b8a.go,42,42,T,T,7,15,F,F,Any,,,Unknown,2.75,8,F,F,F,Other |
There was a problem hiding this comment.
And this is password too. Previous markup is correct.
There was a problem hiding this comment.
Not supported yet. Perhaps it will be with different name
| 22557,2b6903fb,GitHub,fdbe07ac,data/fdbe07ac/test/2b6903fb.go,42,42,T,T,7,15,F,F,Any,,,Secret,2.75,8,F,F,F,Password | ||
| 22557,2b6903fb,GitHub,fdbe07ac,data/fdbe07ac/test/2b6903fb.go,42,42,T,T,7,15,F,F,Any,,,Secret,2.75,8,F,F,F,Other |
csh519
approved these changes
Sep 10, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corrections for Samsung/CredSweeper#600
Password keyword do not applied ConvertTo_SecureString pattern
Other - is used for pattern which are not supported yet. Just for feature.