Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unused properties from application.properties file #419

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Code refactoring - removing unused props in application.properties file.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

@o-kopysov o-kopysov added this to the v1.4.1 milestone Feb 2, 2024
@o-kopysov o-kopysov self-assigned this Feb 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b9604d) 90.90% compared to head (e869c64) 90.90%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #419   +/-   ##
=========================================
  Coverage     90.90%   90.90%           
  Complexity      486      486           
=========================================
  Files            47       47           
  Lines          1737     1737           
  Branches        209      209           
=========================================
  Hits           1579     1579           
  Misses           94       94           
  Partials         64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov o-kopysov merged commit 4e5ccdf into Samsung:main Feb 2, 2024
7 checks passed
@o-kopysov o-kopysov deleted the update-props branch February 2, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants