Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unnecessary try/catch section from the service #447

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

o-kopysov
Copy link
Collaborator

@o-kopysov o-kopysov commented Feb 29, 2024

Pull Request

Description

Remove incorrect code from GitHub service and update UTs.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Test Configuration:

  • Java: v17
  • LPVS Release: v1.4.2

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the fix label Feb 29, 2024
@o-kopysov o-kopysov added this to the v1.4.2 milestone Feb 29, 2024
@o-kopysov o-kopysov self-assigned this Feb 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 87.36842% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 90.74%. Comparing base (d04c45a) to head (648423f).

Files Patch % Lines
.../main/java/com/lpvs/service/LPVSGitHubService.java 89.24% 6 Missing and 4 partials ⚠️
...c/main/java/com/lpvs/service/LPVSQueueService.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #447      +/-   ##
============================================
+ Coverage     90.65%   90.74%   +0.09%     
- Complexity      488      489       +1     
============================================
  Files            47       47              
  Lines          1744     1729      -15     
  Branches        208      208              
============================================
- Hits           1581     1569      -12     
+ Misses           99       97       -2     
+ Partials         64       63       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov o-kopysov marked this pull request as ready for review March 1, 2024 01:37
Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit 843f81f into main Mar 1, 2024
10 checks passed
@o-kopysov o-kopysov deleted the fix-attempts branch March 1, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants