Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix logs and exceptions handling for single scan mode #519

Merged
merged 2 commits into from
May 20, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

PR contains some modification of log messages related to single scan (CLI) operation. Also, provided correct exception handling in case of app closing.

Fixes #512

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Testing is performed for current PR.

Test Configuration:

  • Java: v17
  • LPVS Release: v1.5.0

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the fix label May 18, 2024
@o-kopysov o-kopysov added this to the v1.5.1 milestone May 18, 2024
@o-kopysov o-kopysov self-assigned this May 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 91.47%. Comparing base (e08fe1b) to head (5fb6068).

Files Patch % Lines
...ain/java/com/lpvs/LicensePreValidationService.java 25.00% 3 Missing ⚠️
.../java/com/lpvs/service/scan/LPVSDetectService.java 50.00% 1 Missing and 1 partial ⚠️
...service/scan/scanner/LPVSScanossDetectService.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #519      +/-   ##
============================================
+ Coverage     91.33%   91.47%   +0.14%     
- Complexity      516      520       +4     
============================================
  Files            48       48              
  Lines          1731     1737       +6     
  Branches        208      210       +2     
============================================
+ Hits           1581     1589       +8     
+ Misses           83       82       -1     
+ Partials         67       66       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@o-kopysov o-kopysov force-pushed the single-scan branch 3 times, most recently from fa9713b to ba33ddb Compare May 18, 2024 14:26
@o-kopysov o-kopysov marked this pull request as ready for review May 18, 2024 14:30
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Co-authored-by: Taewan Kim <t25.kim@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov o-kopysov requested a review from tiokim May 20, 2024 03:45
Copy link
Member

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

@o-kopysov o-kopysov merged commit 777dfc8 into main May 20, 2024
10 checks passed
@o-kopysov o-kopysov deleted the single-scan branch May 20, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check the correct operation of the single-scan mode
4 participants