-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix logs and exceptions handling for single scan mode #519
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
============================================
+ Coverage 91.33% 91.47% +0.14%
- Complexity 516 520 +4
============================================
Files 48 48
Lines 1731 1737 +6
Branches 208 210 +2
============================================
+ Hits 1581 1589 +8
+ Misses 83 82 -1
+ Partials 67 66 -1 ☔ View full report in Codecov by Sentry. |
fa9713b
to
ba33ddb
Compare
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Co-authored-by: Taewan Kim <t25.kim@samsung.com> Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution!
Pull Request
Description
PR contains some modification of log messages related to single scan (CLI) operation. Also, provided correct exception handling in case of app closing.
Fixes #512
Type of change
Please delete options that are not relevant.
Testing
Testing is performed for current PR.
Test Configuration:
Checklist: