Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Separate queue service and implement factory for webhooks #599

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

o-kopysov
Copy link
Collaborator

@o-kopysov o-kopysov commented Sep 9, 2024

Pull Request

Description

Current PR contains the refactoring of the queue and queue processing services.

  1. Queue service separated from the webhook processing functionality.
  2. Created webhook service aimed at processing webhooks from the queue.
  3. Created a factory class to allow different implementations of webhook processing classes.
  4. Added missing Javadocs comments.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Tested locally for PR scan and local scan scenarios.
image

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov o-kopysov added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 9, 2024
@o-kopysov o-kopysov added this to the v2.0.0 milestone Sep 9, 2024
@o-kopysov o-kopysov self-assigned this Sep 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 92.07921% with 8 lines in your changes missing coverage. Please review.

Project coverage is 93.71%. Comparing base (5485f13) to head (2d79e81).

Files with missing lines Patch % Lines
...m/lpvs/service/webhook/LPVSWebhookServiceImpl.java 90.69% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #599      +/-   ##
============================================
+ Coverage     93.67%   93.71%   +0.03%     
- Complexity      608      611       +3     
============================================
  Files            49       51       +2     
  Lines          2104     2116      +12     
  Branches        244      244              
============================================
+ Hits           1971     1983      +12     
  Misses           61       61              
  Partials         72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov o-kopysov marked this pull request as ready for review September 10, 2024 05:33
tdrozdovsky
tdrozdovsky previously approved these changes Sep 10, 2024
t-naumenko
t-naumenko previously approved these changes Sep 10, 2024
Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small question, but overall it looks very good!

@@ -6,28 +6,16 @@
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Copyright (c) 2022"
Shouldn't it be updated?

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit dce00d7 into main Sep 10, 2024
10 checks passed
@o-kopysov o-kopysov deleted the ref-queue branch September 10, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants