-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Separate queue service and implement factory for webhooks #599
Conversation
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
============================================
+ Coverage 93.67% 93.71% +0.03%
- Complexity 608 611 +3
============================================
Files 49 51 +2
Lines 2104 2116 +12
Branches 244 244
============================================
+ Hits 1971 1983 +12
Misses 61 61
Partials 72 72 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a small question, but overall it looks very good!
@@ -6,28 +6,16 @@ | |||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Copyright (c) 2022"
Shouldn't it be updated?
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
2d79e81
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request
Description
Current PR contains the refactoring of the queue and queue processing services.
Type of change
Please delete options that are not relevant.
Testing
Tested locally for PR scan and local scan scenarios.

Checklist: