Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix issue with not pinned dependancies for docs generation #604

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

t-naumenko
Copy link
Collaborator

Pull Request

Description

Current PR fix issue with not pinned dependencies of required packages for MkDocs generation.
Changes contain moving from straight forward installing requirements in GitHub Action to installing from requirements.txt which include required packages and their dependencies with version and hashes

Fixes #603

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • CI system update

@t-naumenko t-naumenko added the github_actions Pull requests that update GitHub Actions code label Sep 12, 2024
@t-naumenko t-naumenko added this to the v2.0.0 milestone Sep 12, 2024
@t-naumenko t-naumenko self-assigned this Sep 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.89%. Comparing base (24d6c88) to head (e153892).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #604   +/-   ##
=========================================
  Coverage     93.89%   93.89%           
  Complexity      611      611           
=========================================
  Files            51       51           
  Lines          2112     2112           
  Branches        244      244           
=========================================
  Hits           1983     1983           
  Misses           57       57           
  Partials         72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-naumenko t-naumenko force-pushed the ci/change-docs-requirements-build branch from 4c7bd92 to b46427f Compare September 12, 2024 13:48
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, approved!

Signed-off-by: Tetiana Naumenko <t.naumenko@samsung.com>
@o-kopysov o-kopysov force-pushed the ci/change-docs-requirements-build branch from b46427f to e153892 Compare September 12, 2024 17:53
@o-kopysov o-kopysov merged commit 2714eda into main Sep 12, 2024
10 checks passed
@o-kopysov o-kopysov deleted the ci/change-docs-requirements-build branch September 12, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Pinned-Dependencies
5 participants