Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add queue ID to the PR diffs filepath #617

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Current PR contains the next changes:

  • add queueId to the pull request entity to simplify the debug process
  • add queueId to the file path with pull request diffs to avoid read/write conflicts in case of multithreaded processing.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

@tdrozdovsky Need to run a functional test to check the correctness of the LPVS operation.

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the enhancement New feature or request label Sep 19, 2024
@o-kopysov o-kopysov added this to the v2.0.1 milestone Sep 19, 2024
@o-kopysov o-kopysov self-assigned this Sep 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.46%. Comparing base (4fff427) to head (18171d9).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #617      +/-   ##
============================================
- Coverage     93.94%   93.46%   -0.48%     
+ Complexity      624      623       -1     
============================================
  Files            52       52              
  Lines          2130     2127       -3     
  Branches        248      247       -1     
============================================
- Hits           2001     1988      -13     
- Misses           56       65       +9     
- Partials         73       74       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov o-kopysov merged commit aa59ab7 into main Sep 20, 2024
10 checks passed
@o-kopysov o-kopysov deleted the webhook-id branch September 20, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants