Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: modify Quick Start for docker build #2117

Merged
merged 1 commit into from
Aug 27, 2018
Merged

README: modify Quick Start for docker build #2117

merged 1 commit into from
Aug 27, 2018

Conversation

sunghan-chang
Copy link
Contributor

@sunghan-chang sunghan-chang commented Aug 27, 2018 •
edited
Loading

  1. Mark menuconfig and clean/distclean as optional steps
    with sub-title because they are not essential steps.
    essential steps : install docker -> clone source code -> configure -> build -> program
    optionals : menuconfig and clean

  2. Add the program step.
    This step introduces a programming.

  3. Modify content of clone and clean tabs.

Signed-off-by: sunghan-chang sh924.chang@samsung.com

@seinfra
Copy link

seinfra commented Aug 27, 2018

Target : [c718a559d25e7b6d4dc3fd8dc40323d941c153ab] -

@seinfra
Copy link

seinfra commented Aug 27, 2018

Target : [dd4184029359d7f664f6ea38ac200b12970e1e8c] - Code Rule Check (C++) OK.

@seinfra
Copy link

seinfra commented Aug 27, 2018

Target : [dd4184029359d7f664f6ea38ac200b12970e1e8c] - Code Rule Check OK.

rzr
rzr reviewed Aug 27, 2018
View reviewed changes
Copy link
Contributor

@rzr rzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in commit message:
stpes > steps

@sunghan-chang
Copy link
Contributor Author

@rzr Thank you. I fixed.

@seinfra
Copy link

seinfra commented Aug 27, 2018

Target : [b58a033ed0b777e65d159df379e24dcaa1a7ecac] - Code Rule Check OK.

@seinfra
Copy link

seinfra commented Aug 27, 2018

Target : [b58a033ed0b777e65d159df379e24dcaa1a7ecac] - Code Rule Check (C++) OK.

@rzr
Copy link
Contributor

rzr commented Aug 27, 2018

I guess it should be able to flash from docker too , I also made my dockerfiles I never upstreamed
my blocking point was that I needed the flasher too from artik sdk
since it may be public elsewhere
I will check this out later

@sunghan-chang
Copy link
Contributor Author

@rzr That's why we provide dbuild.sh script. It executes download from script directly, not from docker so that we don't need to import flash tools or set-up usb driver in docker.

davidfather
davidfather reviewed Aug 27, 2018
View reviewed changes
README.md Outdated
**Note**: To contribute in this community, fork this project first into own github repository and do git cloning from your repository.
> git clone https://github.com/your_github_id/TizenRT.git
**Note**: To contribute in this community, you need to clone your forked private repository instead of above.
Github guides it by [working-with-forks](https://help.github.com/articles/working-with-forks).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github guides this.

@sunghan-chang
README: modify Quick Start for docker build
7c95352 
1. Mark menuconfig and clean/distclean as optional steps
   with sub-title because they are not essential steps.
  essential steps : install docker -> clone source code ->
     configure -> build -> program
  optionals : menuconfig and clean

2. Add the program step.
  This step introduces a programming.

3. Modify content of clone and clean tabs.

Signed-off-by: sunghan-chang <sh924.chang@samsung.com>
@seinfra
Copy link

seinfra commented Aug 27, 2018

Target : [7c95352] - Code Rule Check OK.

@seinfra
Copy link

seinfra commented Aug 27, 2018

Target : [7c95352] - Code Rule Check (C++) OK.

davidfather
davidfather approved these changes Aug 27, 2018
View reviewed changes
Copy link
Contributor

@davidfather davidfather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@davidfather davidfather merged commit d824e78 into Samsung:master Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzr rzr rzr left review comments

@davidfather davidfather davidfather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunghan-chang @seinfra @rzr @davidfather