iotjs: Fix (re)connected status in callback #2319
Conversation
|
Target : [1a40a24c77a5b88fa4198ac14c51761ee8e9d034] - Code Rule Check (C++) OK. |
|
Target : [1a40a24c77a5b88fa4198ac14c51761ee8e9d034] - Code Rule Check OK. |
There was a problem hiding this comment.
Basically, in order to enable wifi_manager's reconnect operation, you should set CONFIG_WIFIMGR_INETRNAL_AUTOCONNECT in menuconfig. Moreover, to set it, you first need to set CONFIG_DISABLE_EXTERNAL_AUTOCONNECT, preventing duplicate execution from driver's auto(re)connect.
We do not recommand an application to set a forced reconnect, and acutally, it does not really work.
In case the application requires to get connect/disconnect information, please utilize user callbacks defined in wifi_manager. Thanks.
Note: TizenRT wifi manager "attempt" callback name missleaded me, maybe it could be renamed. Change-Id: Ie4a5bcb397fb7959f2c5954d7a7569052ccc39fb Forwarded: Samsung#2319 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
force-pushed
the
sandbox/rzr/devel/iotjs/review/master
branch
from
1a40a24 to
d0d0538
Compare
|
Target : [d0d0538] - Code Rule Check OK. |
|
Target : [d0d0538] - Code Rule Check (C++) OK. |
rzr
changed the title
Note: TizenRT wifi manager "attempt" callback name missleaded me, maybe it could be renamed. Change-Id: Ie4a5bcb397fb7959f2c5954d7a7569052ccc39fb Forwarded: Samsung#2319 Signed-off-by: Philippe Coval <p.coval@samsung.com>
|
This change have been updated to fix a bug in master, please review and merge |
Note: TizenRT wifi manager "attempt" callback name missleaded me, maybe it could be renamed. Change-Id: Ie4a5bcb397fb7959f2c5954d7a7569052ccc39fb Forwarded: Samsung#2319 Signed-off-by: Philippe Coval <p.coval@samsung.com>
|
This change is desired, should I open a new PR to prevent the ambiguity of the original change ? |
|
Hi @rzr, |
|
Thanks |
This will improve connectivity reliability.
Change-Id: Ie4a5bcb397fb7959f2c5954d7a7569052ccc39fb
Signed-off-by: Philippe Coval p.coval@samsung.com