iotjs: Add modules path option #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Target : [ce76779058a12e30b5517683473263c918e72864] - Code Rule Check Result: |
|
Target : [ce76779058a12e30b5517683473263c918e72864] - Code Rule Check (C++) OK. |
rzr
added a commit
to rzr/TizenRT
that referenced
this pull request
Oct 19, 2018
Change-Id: I1cc40989e45527c40d96838f12652610f7abbf85 Forwarded: Samsung#2360 Signed-off-by: Philippe Coval <p.coval@samsung.com>
sunghan-chang
requested changes
Oct 22, 2018
| @@ -112,6 +116,7 @@ int main(int argc, FAR char *argv[]) | |||
| int iotjs_startup_main(int argc, char *argv[]) | |||
| #endif | |||
| { | |||
| setenv("IOTJS_EXTRA_MODULE_PATH", CONFIG_EXAMPLES_IOTJS_EXTRA_MODULE_PATH, 1); | |||
There was a problem hiding this comment.
Could you use a tab instead of spaces at start of line as indentation? That is an our coding rule and we must follow it in apps folder.
Change-Id: I1cc40989e45527c40d96838f12652610f7abbf85 Forwarded: Samsung#2360 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
force-pushed
the
sandbox/rzr/iotjs/review/master
branch
from
ce76779 to
4b56517
Compare
|
Target : [4b56517] - Code Rule Check (C++) OK. |
|
Target : [4b56517] - Code Rule Check OK. |
sunghan-chang
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I1cc40989e45527c40d96838f12652610f7abbf85
Signed-off-by: Philippe Coval p.coval@samsung.com