Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating how wheels are being built. Fixing py36,37 support #6

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

martinhoyer
Copy link
Contributor

As mentioned in #5, current netifaces2 wheels are broken on python3.6. PyO3 dropped 3.6 support in 0.16.
I've tried to update the build process to increase compatibility and switch to building py37 abi3 wheels.

  • Linting step was failing on install: Fixed by installing maturin
  • Moving to manylinux_2_28
  • Cross compiling linux wheels to more architectures
  • Building musllinux wheels
  • Touching up the pyproject.toml
  • Trying (ugly) py36 wheel building. Needs changes in Cargo.toml and pyproject.toml before being build.
  • In defs.py, there is from typing import Literal, which was only introduced in 3.8:
    Solved by using [typing-extensions](https://pypi.org/project/typing-extensions/).

So far I only tested the linux py37-abi3 x86_64 wheel on Python 3.9 (el.8) and cpy36m manylinux2014 x86_64 wheel on Python 3.6 (el.7), both seemed to be working fine.

.github/workflows/CI.yml Outdated Show resolved Hide resolved
Copy link
Owner

@SamuelYvon SamuelYvon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to wheels and I think we are good to go :)

.github/workflows/CI.yml Outdated Show resolved Hide resolved
@SamuelYvon
Copy link
Owner

All passed, looks good to me. Will merge; for the sed hack if you think of something else feel free to lmk, I'll try to come up with a better solution but I'm not sure there's an obvious one.

@SamuelYvon SamuelYvon merged commit 99d9c13 into SamuelYvon:dev Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants