Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] overall optimizations; add getRows to exd data; #927

Merged
merged 5 commits into from
Mar 25, 2023

Conversation

hkAlice
Copy link
Member

@hkAlice hkAlice commented Mar 24, 2023

45s -> 28s (37%) to start world server up on debug (5900x)

getRows should be used instead of getIdList then looping through the list to manually get the exd data.
I've gone through and replaced most of the getIdList calls on the project.

example:

auto contentListIds = exdData.getIdList< Excel::InstanceContent >();

  for( auto id : contentListIds )
  {
    auto instanceContent = exdData.getRow< Excel::InstanceContent >( id );
    if( instanceContent->data().TerritoryType == territoryTypeId )
    {
      return id;
    }
  }

should now be:

auto contentFinderList = exdData.getRows< Excel::InstanceContent >();

  for( const auto& [ id, instanceContent ] : contentFinderList )
  {
    if( instanceContent->data().TerritoryType == territoryTypeId )
    {
      return id;
    }
  }

@SapphireMordred SapphireMordred merged commit a65b237 into SapphireServer:master Mar 25, 2023
IceyMint pushed a commit to IceyMint/Sapphire that referenced this pull request Sep 8, 2024
[3.x] overall optimizations; add getRows to exd data;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants