fixes major code smells in GenericUtils.java #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hks1
commented
Jul 14, 2022
•
hks1
commented
- Adds a private constructor
- Adds missing 'Deprecated' annotation
src/main/java/org/sasanlabs/internal/utility/JSONSerializationUtils.java
Outdated
Show resolved
Hide resolved
| @@ -9,11 +9,14 @@ public class GenericUtils { | |||
|
|
|||
| public static final String LOCALHOST = "127.0.0.1"; | |||
|
|
|||
| private GenericUtils() {} | |||
There was a problem hiding this comment.
can you please mark this class as final as well?
src/main/java/org/sasanlabs/internal/utility/JSONSerializationUtils.java
Outdated
Show resolved
Hide resolved
|
@hks1 Thank you !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.