Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework inventory cli #324

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Conversation

JacobCallahan
Copy link
Member

With the changes we've been making in 0.6 toward a better, more customizable and visually appealing, user experience. It's time that we revisited the inventory command.
The --curated view introduced in 0.5.x has now become the default inventory view. The original default view is now present in its new form and home with the --list flag.
The --details flag largely retains the functionality it did before. However, it involves much less processing than before.

One important piece added in this is the ability to customize the inventory fields on a per-user basis. The details on this customization are documented in detail in the supporting code.
It will also be important to document this in the wiki upon release.

Here's a screenshot of what the new changes look like (with the details view cut-off for security).
Screenshot from 2024-10-07 16-26-56

@JacobCallahan JacobCallahan added enhancement New feature or request 0.6 Things aligned to the 0.6 release labels Oct 7, 2024
broker/commands.py Outdated Show resolved Hide resolved
broker/config_migrations/v0_6_0.py Show resolved Hide resolved
broker/commands.py Outdated Show resolved Hide resolved
broker_settings.yaml.example Show resolved Hide resolved
With the changes we've been making in 0.6 toward a better, more
customizable and visually appealing, user experience. It's time that we
revisited the inventory command.
The --curated view introduced in 0.5.x has now become the default
inventory view. The original default view is now present in its new form
and home with the --list flag.
The --details flag largely retains the functionality it did before.
However, it involves much less processing than before.

One important piece added in this is the ability to customize the
inventory fields on a per-user basis. The details on this customization
are documented in detail in the supporting code.
It will also be important to document this in the wiki upon release.
@JacobCallahan JacobCallahan marked this pull request as ready for review October 8, 2024 12:19
In case people want to have a more plain output.
@JacobCallahan
Copy link
Member Author

@ogajduse enjoy.... lol
The color in there is likely just from how my terminal is setup to handle bolded text.
Screenshot from 2024-10-08 09-33-49

I had forgot the include logic to not run some migrations if the changes
have already taken place. This skip is just the "naive" approach instead
of doing a complete validation that the previous fields have migrated.
broker/helpers.py Outdated Show resolved Hide resolved
Co-authored-by: Tasos Papaioannou <tpapaioa@redhat.com>
@JacobCallahan JacobCallahan merged commit 5cad1d2 into SatelliteQE:0.6 Oct 10, 2024
4 checks passed
@JacobCallahan JacobCallahan deleted the inventory_refactor branch October 13, 2024 20:32
@JacobCallahan JacobCallahan mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.6 Things aligned to the 0.6 release enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants