More fixes #328
Merged
More fixes #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcreech
reviewed
Oct 15, 2024
| @@ -326,6 +326,9 @@ def inventory(details, _list, sync, filter): | |||
| ) | |||
| for host in inventory | |||
| ] | |||
| if not curated_host_info: | |||
| CONSOLE.print("No hosts found in inventory.") | |||
| return | |||
There was a problem hiding this comment.
Confirmed that this resolves the inventory issues I saw.
$ broker inventory
No hosts found in inventory.
These include resolving a problem with interactive edits on mac not working. This was likely due to a quirk with the NamedTemporaryFile implementation. I insteda switched to manually creating a temporary file and that worked. It also includes an early escape for when a user's inventory is empty.
JacobCallahan
force-pushed
the
quickfix
branch
from
82dfa34
to
7ab6d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These include resolving a problem with interactive edits on mac not working. This was likely due to a quirk with the NamedTemporaryFile implementation. I insteda switched to manually creating a temporary file and that worked.
It also includes an early escape for when a user's inventory is empty.