Update host connect method to handle IPv6 address #351
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobCallahan
requested changes
Feb 13, 2025
broker/hosts.py
Outdated
| @@ -126,8 +126,9 @@ def connect( | |||
| _port = self.port or port | |||
| key_filename = key_filename or self.key_filename | |||
| if ":" in self.hostname: | |||
There was a problem hiding this comment.
maybe easier if we just do something like this
Suggested change
| if ":" in self.hostname: | |
| if ":" in self.hostname and not ipv6: |
Signed-off-by: Shubham Ganar <sganar@redhat.com>
shubhamsg199
force-pushed
the
update_host_connect
branch
from
3c0f200 to
45bd841
Compare
JacobCallahan
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement :
The connect method does not work with IPv6 addresses. It returns an error
Solution :
Update host connect method to handle IPv6 address