Remove katello-agent related entities #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsedmik
added
No-CherryPick
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1012 +/- ##
==========================================
- Coverage 92.18% 92.15% -0.03%
==========================================
Files 6 6
Lines 3057 3047 -10
==========================================
- Hits 2818 2808 -10
Misses 239 239
☔ View full report in Codecov by Sentry. |
|
rebased |
| @@ -4378,44 +4378,6 @@ def errata_applicability(self, synchronous=True, timeout=None, **kwargs): | |||
| response = client.put(self.path('errata/applicability'), **kwargs) | |||
| return _handle_response(response, self._server_config, synchronous, timeout) | |||
|
|
|||
| def errata_apply(self, synchronous=True, timeout=None, **kwargs): | |||
There was a problem hiding this comment.
Can we remove errata_applicability method too as it is also removed right?
There was a problem hiding this comment.
Negative. Errata applicability recalculation functionality remains present.
[GET /api/hosts/:host_id/errata] List errata available for the content host
[GET /api/hosts/:host_id/errata/:id] Retrieve a single errata for a host
[PUT /api/hosts/:host_id/errata/applicability] Force regenerate applicability.
Katello-agent was deprecated and removed from 6.15 including related API endpoints. This PR removes those supported in nailgun.
damoore044
approved these changes
Oct 20, 2023
sambible
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Katello-agent was deprecated and removed from 6.15 including related API endpoints. This PR removes those supported in nailgun.
Upstream API documentation, plugin, or feature links
See the 6.15 apidoc for these particular endpoint. They are missing.
Functional demonstration
Additional Information
Robottelo PR for removal of the last used endpoint (
/api/hosts/bulk/install_content) - SatelliteQE/robottelo#12817