Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.12.z] update entity object with parametrized server_config rather default #1110

Conversation

Satellite-QE
Copy link
Contributor

Cherrypick of PR: #1106

Description of changes

Currently server_config was not getting set while reading the entity API call using target_sat

        dom = target_sat.api.Domain(server_config=sc, id=dom.id).read()
        dom.organization = [filter_taxonomies['org']]
        with pytest.raises(HTTPError):
            dom.update(['organization']) 

After this PR the dom object or any other api component object can access the API calls using the custom server_config set by parameter .

@Satellite-QE Satellite-QE added 6.12.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches labels Mar 7, 2024
@Satellite-QE
Copy link
Contributor Author

trigger: test-robottelo
pytest: -k test_negative_assign_taxonomies_by_org_admin tests/foreman/api/test_role.py

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (6.12.z@3aa5591). Click here to learn what that means.

Files Patch % Lines
nailgun/entity_mixins.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             6.12.z    #1110   +/-   ##
=========================================
  Coverage          ?   93.19%           
=========================================
  Files             ?        6           
  Lines             ?     2925           
  Branches          ?        0           
=========================================
  Hits              ?     2726           
  Misses            ?      199           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pondrejk pondrejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack pending test result

@Gauravtalreja1 Gauravtalreja1 merged commit 263e48c into 6.12.z Apr 9, 2024
15 of 16 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.12.z-42f30208f429258134bc204090b230e722cdca0b branch April 9, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants