[6.14.z] Use type(self) instead of entity class name in create methods #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit d5545c1)
Satellite-QE
added
6.14.z
Auto_Cherry_Picked
tpapaioa
deleted the
cherry-pick-6.14.z-d5545c17d2fd32deddc9ebe69ae29c9637f76467
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #1143
Description of changes
Before this PR, the entity classes that override the
EntityCreateMixin.createmethod return a new instance of thenailgun.entities.ENTITYclass. In robottelo, which wraps each entity class in therobottelo.hosts.DecClassclass, this causes test failures, becausesatellite.api.ENTITY().create()returns an instance ofrobottelo.hosts.DecClassfor some classes andnailgun.entities.ENTITYinstances for others.This PR updates those
createmethods to return an instance oftype(self)instead of explicitly naming the class, so that an the same subclass / decorated class is used.No functionality changes.