Add support for delete with args, and republish_repositories endpoints #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambible
added
No-CherryPick
sambible
force-pushed
the
podman-push-support
branch
from
e1a7843
to
0c3cb26
Compare
JacobCallahan
previously requested changes
Jul 30, 2024
vijaysawant
reviewed
Aug 1, 2024
vijaysawant
previously approved these changes
Aug 1, 2024
Co-authored-by: vijay sawant <visawant@redhat.com>
JacobCallahan
approved these changes
Aug 6, 2024
ColeHiggins2
approved these changes
Aug 7, 2024
damoore044
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for one new endpoint, republish_repositories, as well as adding in a newly added field, is_container_push to support the podman push feature for 6.16.
Additionally, this adds a version of the delete endpoint for a repository that respects arguments passed to it. There certainly could be a more elegant way to do this, perhaps reworking the Delete mixin entirely to support arguments, but as far as I'm aware this isn't something that is required in the vast case of all entities, so I decided to make a more local change, and just add a separate endpoint for repositories.
This is in support of this robottelo PR: SatelliteQE/robottelo#14940