Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and remove ansible_role to host/hostgroup (#927) #929

Merged

Conversation

Gauravtalreja1
Copy link
Collaborator

Manual cherrypick of #927

* Add and remove ansible_role to host/hostgroup

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>

* Add unittests for add and remove ansible_roles

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>

---------

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit 183828a)
@Gauravtalreja1 Gauravtalreja1 added No-CherryPick PR doesnt need CherryPick to previous branches 6.14.z labels Jun 14, 2023
@Gauravtalreja1 Gauravtalreja1 self-assigned this Jun 14, 2023
@Gauravtalreja1 Gauravtalreja1 changed the base branch from master to 6.14.z June 14, 2023 08:22
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.34 🎉

Comparison is base (27932aa) 91.83% compared to head (1228d96) 92.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           6.14.z     #929      +/-   ##
==========================================
+ Coverage   91.83%   92.18%   +0.34%     
==========================================
  Files           6        6              
  Lines        3001     3031      +30     
==========================================
+ Hits         2756     2794      +38     
+ Misses        245      237       -8     
Impacted Files Coverage Δ
nailgun/entities.py 91.22% <100.00%> (+0.45%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@omkarkhatavkar omkarkhatavkar merged commit d425944 into SatelliteQE:6.14.z Jun 14, 2023
@Gauravtalreja1 Gauravtalreja1 deleted the add_remove_ansible_role-614z branch June 14, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants