Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for BZ#2250397 #14465

Merged
merged 1 commit into from
May 2, 2024
Merged

Add test coverage for BZ#2250397 #14465

merged 1 commit into from
May 2, 2024

Conversation

shubhamsg199
Copy link
Contributor

Adding Closed loop for BZ#2250397 covering host registration with custom facts

@shubhamsg199 shubhamsg199 added QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 20, 2024
@shubhamsg199 shubhamsg199 self-assigned this Mar 20, 2024
@shubhamsg199 shubhamsg199 requested a review from a team as a code owner March 20, 2024 17:41
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6148
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration --external-logging
Test Result : =========== 1 failed, 15 deselected, 1 warning in 810.18s (0:13:30) ============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 20, 2024
@shubhamsg199 shubhamsg199 force-pushed the closed_loop_fact_2250397 branch 2 times, most recently from 2794c36 to 6b044ad Compare March 20, 2024 18:12
@shubhamsg199 shubhamsg199 removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 20, 2024
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6150
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration --external-logging
Test Result : =========== 1 passed, 15 deselected, 1 warning in 1264.08s (0:21:04) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 20, 2024
Gauravtalreja1
Gauravtalreja1 reviewed Mar 21, 2024
View reviewed changes
tests/foreman/cli/test_registration.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_registration.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_registration.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_registration.py Outdated Show resolved Hide resolved
@shubhamsg199 shubhamsg199 force-pushed the closed_loop_fact_2250397 branch 2 times, most recently from b04f82b to b36f205 Compare March 21, 2024 15:46
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 21, 2024
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6155
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration --external-logging
Test Result : =========== 1 passed, 15 deselected, 1 warning in 752.56s (0:12:32) ============

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 21, 2024
Gauravtalreja1
Gauravtalreja1 reviewed Mar 22, 2024
View reviewed changes
tests/foreman/cli/test_registration.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_registration.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_registration.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_registration.py Show resolved Hide resolved
lhellebr
lhellebr approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@lhellebr lhellebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending Gaurav's comments

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 3, 2024
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6286
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration --external-logging
Test Result : =========== 1 failed, 15 deselected, 4 warnings in 701.24s (0:11:41) ===========

@shubhamsg199 shubhamsg199 force-pushed the closed_loop_fact_2250397 branch 2 times, most recently from 43395d3 to d261235 Compare April 3, 2024 13:29
@Satellite-QE Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 3, 2024
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6307
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration --external-logging
Test Result : =========== 1 failed, 15 deselected, 4 warnings in 701.22s (0:11:41) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 4, 2024
@Satellite-QE Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 4, 2024
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6320
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration --external-logging
Test Result : =========== 1 failed, 15 deselected, 4 warnings in 927.35s (0:15:27) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 5, 2024
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6324
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration --external-logging
Test Result : =========== 1 failed, 15 deselected, 4 warnings in 890.36s (0:14:50) ===========

@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6404
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration --external-logging
Test Result : =========== 1 failed, 15 deselected, 4 warnings in 637.21s (0:10:37) ===========

@shubhamsg199
Add closed loop BZ#2250397
176ebf4 
Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration

1 similar comment
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6546
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_positive_custom_facts_for_host_registration --external-logging
Test Result : ========== 1 passed, 15 deselected, 24 warnings in 796.47s (0:13:16) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Apr 17, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit b37a3c7 into SatelliteQE:master May 2, 2024
10 of 11 checks passed
github-actions bot pushed a commit that referenced this pull request May 2, 2024
@shubhamsg199 @web-flow
Add test coverage for BZ#2250397 (#14465)
b5395ef 
Add closed loop BZ#2250397

Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
(cherry picked from commit b37a3c7)
@Satellite-QE Satellite-QE mentioned this pull request May 2, 2024
Merged
github-actions bot pushed a commit that referenced this pull request May 2, 2024
@shubhamsg199 @web-flow
Add test coverage for BZ#2250397 (#14465)
73e9110 
Add closed loop BZ#2250397

Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
(cherry picked from commit b37a3c7)
@Satellite-QE Satellite-QE mentioned this pull request May 2, 2024
Draft
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@shubhamsg199 @jyejare
Add test coverage for BZ#2250397 (SatelliteQE#14465)
3dfacf5 
Add closed loop BZ#2250397

Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhellebr lhellebr lhellebr approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@shubhamsg199 shubhamsg199

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shubhamsg199 @Satellite-QE @lhellebr @Gauravtalreja1