Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stream] Errata-UI: Fix test_positive_host_content_library #14926

Merged

Conversation

damoore044
Copy link
Contributor

@damoore044 damoore044 commented Apr 30, 2024

Problem Statement

  • outdated setup using old fixtures and deprecated methods.
  • Resolved conflict with newly introduced case from (recently merged commit).
    ^ Above commit renamed test_positive_content_host_library to test_positive_check_errata,
    and rewrote as a fundamental quick check of New Host > content > errata details.
    So test_positive_check_errata it could be a new smaller case, I gave it a unique :id, and made tier2 importance.
    I think it's still good to retain this PRs changes for test_positive_host_content_library, which is searching and reading the full errata tables displayed in UI, for new host and legacy chost.

Solution

PRT Case

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py::test_positive_host_content_library
airgun: 1374

@damoore044 damoore044 added CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 30, 2024
@damoore044 damoore044 self-assigned this Apr 30, 2024
@damoore044 damoore044 requested a review from a team as a code owner April 30, 2024 15:40
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py::test_positive_host_content_library
airgun: 1374

@damoore044 damoore044 changed the title [Errata UI] Fix test_positive_host_content_library [Stream] Errata-UI: Fix test_positive_host_content_library Apr 30, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6750
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py::test_positive_host_content_library --external-logging
Test Result : ================= 2 passed, 85 warnings in 1065.15s (0:17:45) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 30, 2024
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good, but the new airgun method needs to be cleaned up, and will require changes here as well.

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py::test_positive_host_content_library
airgun: 1374

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 30, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6752
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py::test_positive_host_content_library --external-logging
Test Result : ================= 2 passed, 88 warnings in 1184.84s (0:19:44) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 30, 2024
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py::test_positive_host_content_library
airgun: 1374

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6754
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py::test_positive_host_content_library --external-logging
Test Result : ================= 2 passed, 87 warnings in 1099.76s (0:18:19) ==================

@damoore044 damoore044 requested review from a team, vijaysawant, vsedmik and ColeHiggins2 and removed request for a team May 1, 2024 15:30
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py::test_positive_host_content_library
airgun: 1374

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 1, 2024
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_positive_host_content_library or test_positive_check_errata and not test_positive_check_errata_counts_by_type_on_host_details_page'
airgun: 1374

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6759
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py::test_positive_host_content_library --external-logging
Test Result : ================= 2 passed, 82 warnings in 1094.79s (0:18:14) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 1, 2024
Fix conflict with new UI test case.
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py::test_positive_host_content_library
airgun: 1374

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 1, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6760
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py -k test_positive_host_content_library or test_positive_check_errata and not test_positive_check_errata_counts_by_type_on_host_details_page --external-logging
Test Result : ========= 3 passed, 15 deselected, 145 warnings in 1421.36s (0:23:41) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 1, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6761
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py::test_positive_host_content_library --external-logging
Test Result : ================= 2 passed, 82 warnings in 1153.84s (0:19:13) ==================

Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack pending comments

@Griffin-Sullivan Griffin-Sullivan merged commit ddd6cca into SatelliteQE:master May 1, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request May 1, 2024
Updates for new host, and legacy chost pages

Fix conflict with new UI test case.

(cherry picked from commit ddd6cca)
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
…QE#14926)

Updates for new host, and legacy chost pages

Fix conflict with new UI test case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants