Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add negative test case for ipv6 enabled in boot options #15062

Merged
merged 1 commit into from
May 14, 2024

Conversation

Griffin-Sullivan
Copy link
Contributor

Problem Statement

Customers are hitting an upgrade issue when ipv6.disable=1 is present in boot options. theforeman/foreman_maintain#847 adds an upgrade check for ipv6.disable.

Solution

Add a destructive test to check if this upgrade check is working.

Related Issues

Requires changes from #14883

@Griffin-Sullivan Griffin-Sullivan added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 14, 2024
@Griffin-Sullivan Griffin-Sullivan requested review from a team as code owners May 14, 2024 14:48
@Griffin-Sullivan
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_fm_upgrade.py
theforeman:
    foreman_maintain: 847

@Griffin-Sullivan
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_fm_upgrade.py
theforeman:
    foreman_maintain: 847


:expectedresults: Update check fails due to ipv6.disable=1 in boot options
"""
result = sat_maintain.execute('grubby --args="ipv6.disable=1" --update-kernel=ALL')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does sat_maintain here represent the CLI tool or a host? As my question hopefully implies, I find this very confusing :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's not my favorite design but it makes testing for capsule vs satellite very easy since satellite-maintain has the same commands for both.

def sat_maintain(request, module_target_sat, module_capsule_configured):

The sat_maintain fixture spins up a Satellite and Capsule, and then the correct one is returned based on which test you're running. You'll see in this scenario I have include_capsule on https://github.com/SatelliteQE/robottelo/pull/15062/files#diff-f514a11bb5043f68643019fff6bf6af426fb404a3525bc49ec3b4af920234373R20. This parameterizes this test to run once on a Satellite and once on a Capsule. The sat_maintain fixture already made one of each so we just pass along the right one for each test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be improved with better naming :) (something I'm bad at)

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6926
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_fm_upgrade.py --external-logging
Test Result : ============ 1 failed, 1 passed, 476 warnings in 8131.22s (2:15:31) ============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 14, 2024
@Griffin-Sullivan
Copy link
Contributor Author

I keep forgetting we haven't added support for upstream capsule testing yet 🤦. This one is good to go after I rebase.

@Griffin-Sullivan Griffin-Sullivan added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels May 14, 2024
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 14, 2024
@synkd synkd merged commit e4df53e into SatelliteQE:master May 14, 2024
9 checks passed
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants