-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add negative test case for ipv6 enabled in boot options #15062
Conversation
|
4d3f49c
to
8996053
Compare
|
|
||
:expectedresults: Update check fails due to ipv6.disable=1 in boot options | ||
""" | ||
result = sat_maintain.execute('grubby --args="ipv6.disable=1" --update-kernel=ALL') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does sat_maintain
here represent the CLI tool or a host? As my question hopefully implies, I find this very confusing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's not my favorite design but it makes testing for capsule vs satellite very easy since satellite-maintain has the same commands for both.
def sat_maintain(request, module_target_sat, module_capsule_configured): |
The sat_maintain
fixture spins up a Satellite and Capsule, and then the correct one is returned based on which test you're running. You'll see in this scenario I have include_capsule
on https://github.com/SatelliteQE/robottelo/pull/15062/files#diff-f514a11bb5043f68643019fff6bf6af426fb404a3525bc49ec3b4af920234373R20. This parameterizes this test to run once on a Satellite and once on a Capsule. The sat_maintain
fixture already made one of each so we just pass along the right one for each test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be improved with better naming :) (something I'm bad at)
PRT Result
|
I keep forgetting we haven't added support for upstream capsule testing yet 🤦. This one is good to go after I rebase. |
8996053
to
724895b
Compare
724895b
to
b55f4f8
Compare
…15062) Add negative test for ipv6 update check
Problem Statement
Customers are hitting an upgrade issue when ipv6.disable=1 is present in boot options. theforeman/foreman_maintain#847 adds an upgrade check for ipv6.disable.
Solution
Add a destructive test to check if this upgrade check is working.
Related Issues
Requires changes from #14883