Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify test_positive_import_all_roles to cover non-admin scenario #15171

Merged
merged 1 commit into from
May 31, 2024
Merged

Modify test_positive_import_all_roles to cover non-admin scenario #15171

merged 1 commit into from
May 31, 2024

Conversation

Gauravtalreja1
Copy link
Collaborator

Problem Statement

Currently, test_positive_import_all_roles covers only admin scenario to import all roles via UI, and as part of component audit its suggest to modify this test to cover non-admin user scenario

Solution

Parametrizing the existing test to cover both admin and non-admin user scenarios with few more changes

@Gauravtalreja1 Gauravtalreja1 added QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 23, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this May 23, 2024
@Gauravtalreja1 Gauravtalreja1 requested review from a team as code owners May 23, 2024 22:34
@Gauravtalreja1 Gauravtalreja1 force-pushed the ansible-non-admin-importallrole branch from a38aa5d to 1bab74e Compare May 23, 2024 22:36
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ansible.py::test_positive_import_all_roles

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7108
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ansible.py::test_positive_import_all_roles --external-logging
Test Result : ================= 176 warnings, 2 errors in 2007.16s (0:33:27) =================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 23, 2024
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ansible.py::test_positive_import_all_roles

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7115
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ansible.py::test_positive_import_all_roles --external-logging
Test Result : ================= 173 warnings, 2 errors in 1979.93s (0:32:59) =================

@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ansible.py::test_positive_import_all_roles

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7148
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ansible.py::test_positive_import_all_roles --external-logging
Test Result : ================= 181 warnings, 2 errors in 2063.42s (0:34:23) =================

@Gauravtalreja1 Gauravtalreja1 force-pushed the ansible-non-admin-importallrole branch from 1bab74e to 7b15ecf Compare May 28, 2024 19:25
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ansible.py::test_positive_import_all_roles

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7150
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ansible.py::test_positive_import_all_roles --external-logging
Test Result : ================= 2 passed, 187 warnings in 2261.01s (0:37:41) =================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels May 28, 2024
synkd
synkd approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@synkd synkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, so ACK.

Out of curiosity, though, what did you need to change to get PRT passing? I looked at one of the failures this morning and it appeared to be an issue with the function_org fixture.

@Gauravtalreja1
Copy link
Collaborator Author

Yes, the PRT failure earlier was due to SatelliteQE/nailgun#1038, which was fixed by @tpapaioa in SatelliteQE/nailgun#1152, Thanks!

@Gauravtalreja1
Modify test_positive_import_all_roles to cover non-admin scenario
e2d7f13 
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
@Gauravtalreja1 Gauravtalreja1 force-pushed the ansible-non-admin-importallrole branch from 7b15ecf to e2d7f13 Compare May 30, 2024 21:47
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ansible.py::test_positive_import_all_roles

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 30, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7221
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ansible.py::test_positive_import_all_roles --external-logging
Test Result : ================= 2 passed, 194 warnings in 2204.28s (0:36:44) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 30, 2024
@omkarkhatavkar omkarkhatavkar merged commit ba922c8 into SatelliteQE:master May 31, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request May 31, 2024
@Gauravtalreja1 @web-flow
Modify test_positive_import_all_roles to cover non-admin scenario (#1…
0006e44 
…5171)

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit ba922c8)
@Satellite-QE Satellite-QE mentioned this pull request May 31, 2024
Merged
github-actions bot pushed a commit that referenced this pull request May 31, 2024
@Gauravtalreja1 @web-flow
Modify test_positive_import_all_roles to cover non-admin scenario (#1…
97c363c 
…5171)

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit ba922c8)
github-actions bot pushed a commit that referenced this pull request May 31, 2024
@Gauravtalreja1 @web-flow
Modify test_positive_import_all_roles to cover non-admin scenario (#1…
be7c259 
…5171)

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit ba922c8)
This was referenced May 31, 2024
Merged
Merged
@Gauravtalreja1 Gauravtalreja1 deleted the ansible-non-admin-importallrole branch May 31, 2024 06:56
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@Gauravtalreja1 @jyejare
Modify test_positive_import_all_roles to cover non-admin scenario (Sa…
7b80664 
…telliteQE#15171)

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synkd synkd synkd approved these changes

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@omkarkhatavkar omkarkhatavkar Awaiting requested review from omkarkhatavkar

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gauravtalreja1 @Satellite-QE @omkarkhatavkar @synkd @shubhamsg199