Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DecClass to use server_config kwarg consistently #15197

Closed

Conversation

tpapaioa
Copy link
Contributor

@tpapaioa tpapaioa commented May 28, 2024

This change is actually not needed. Closing PR.

Problem Statement

Fixes SatelliteQE/nailgun#1038

pytest_fixtures/component/taxonomy.py:43: in module_org
    return module_target_sat.api.Organization().create()
../../lib64/python3.12/site-packages/nailgun/entities.py:5803: in create
    return type(self)(
E   TypeError: Organization.__init__() got multiple values for argument 'server_config'

Also requires SatelliteQE/nailgun#1152
Fixes SatelliteQE/nailgun#1038

Solution

Update the init method in robottelo.hosts.DecClass to pass the server_config kwarg correctly, if the caller also passes in a server_config. In that case, the passed in server_config will be used instead of the default passed in by robottelo.

Related Issues

SatelliteQE/nailgun#1038

@tpapaioa tpapaioa added 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 28, 2024
@tpapaioa tpapaioa self-assigned this May 28, 2024
@tpapaioa
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_organization.py
nailgun: 1152

@tpapaioa tpapaioa added the CherryPick PR needs CherryPick to previous branches label May 28, 2024
@tpapaioa tpapaioa force-pushed the update_nailgun_entity_config branch from 0b460e3 to 4e4e9d8 Compare May 28, 2024 13:51
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7140
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_organization.py --external-logging
Test Result : ================= 43 passed, 238 warnings in 799.81s (0:13:19) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 28, 2024
@tpapaioa tpapaioa marked this pull request as ready for review May 28, 2024 14:10
@tpapaioa tpapaioa requested a review from a team as a code owner May 28, 2024 14:10
@tpapaioa tpapaioa marked this pull request as draft May 28, 2024 14:20
@tpapaioa tpapaioa closed this May 28, 2024
@tpapaioa tpapaioa deleted the update_nailgun_entity_config branch May 28, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x.__init__() got multiple values for argument 'server_config'
2 participants