Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.16]Add test for podman push on capsule #15884

Merged
merged 8 commits into from
Aug 22, 2024
Merged

[6.16]Add test for podman push on capsule #15884

merged 8 commits into from
Aug 22, 2024

Conversation

sambible
Copy link
Contributor

@sambible sambible commented Aug 7, 2024

Last test for Podman push feature for 6.16, requires a new version of smart_proxy_container_gateway to be released.

@sambible sambible added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Aug 7, 2024
@sambible sambible self-assigned this Aug 7, 2024
@sambible sambible requested a review from a team as a code owner August 7, 2024 19:28
vsedmik
vsedmik requested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One proposal for change.

tests/foreman/api/test_capsulecontent.py Show resolved Hide resolved
ogajduse
ogajduse requested changes Aug 12, 2024
View reviewed changes
tests/foreman/api/test_capsulecontent.py Outdated Show resolved Hide resolved
tests/foreman/api/test_capsulecontent.py Outdated Show resolved Hide resolved
tests/foreman/api/test_capsulecontent.py Outdated Show resolved Hide resolved
rmynar
rmynar requested changes Aug 12, 2024
View reviewed changes
tests/foreman/api/test_capsulecontent.py Outdated Show resolved Hide resolved
@sambible sambible mentioned this pull request Aug 16, 2024
Open
@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_capsulecontent.py -k 'test_negative_podman_capsule_push'

@sambible sambible added CherryPick PR needs CherryPick to previous branches 6.16.z Introduced in or relating directly to Satellite 6.16 and removed No-CherryPick PR doesnt need CherryPick to previous branches labels Aug 21, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8226
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_capsulecontent.py -k test_negative_podman_capsule_push --external-logging
Test Result : ========== 24 deselected, 36 warnings, 1 error in 1727.39s (0:28:47) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Aug 21, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8229
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_capsulecontent.py -k test_negative_podman_capsule_push --external-logging
Test Result : ========== 1 failed, 24 deselected, 37 warnings in 3013.70s (0:50:13) ==========

@sambible
Copy link
Contributor Author

Having a hard time getting this to pass in PRT, since it requires a Stream 71 capsule to work properly. It's passing with a locally configured stream 71 capsule, so hopefully we can get this merged up.

@vsedmik
Copy link
Contributor

vsedmik commented Aug 22, 2024

c39657f should imho reslove the PRT, let's give it a try.

@vsedmik
Copy link
Contributor

vsedmik commented Aug 22, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_capsulecontent.py -k 'test_negative_podman_capsule_push'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8244
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_capsulecontent.py -k test_negative_podman_capsule_push --external-logging
Test Result : ========== 1 passed, 24 deselected, 37 warnings in 3056.32s (0:50:56) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Aug 22, 2024
@vsedmik vsedmik merged commit d936434 into SatelliteQE:master Aug 22, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 22, 2024
@sambible @web-flow
[6.16]Add test for podman push on capsule (#15884)
6721afe 
* Add test for podman push on capsule

* Address review comments

* remove old assertion

* Adjust final assert

(cherry picked from commit d936434)
@Satellite-QE Satellite-QE mentioned this pull request Aug 22, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@sambible @jyejare
[6.16]Add test for podman push on capsule (SatelliteQE#15884)
108b999 
* Add test for podman push on capsule

* Address review comments

* remove old assertion

* Adjust final assert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogajduse ogajduse ogajduse requested changes

@vsedmik vsedmik vsedmik approved these changes

@rmynar rmynar rmynar approved these changes

Assignees

@sambible sambible

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sambible @Satellite-QE @vsedmik @ogajduse @rmynar