Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pve-edk2-firmware: fix upstream submodule broken #79

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

5aaee9
Copy link
Contributor

@5aaee9 5aaee9 commented Nov 7, 2024

Upstream subhook repo is gone. Repalced with tianocore fork.

Links:

tianocore/edk2#6398
NixOS/nixpkgs#353800

@heywoodlh
Copy link

heywoodlh commented Nov 19, 2024

When attempting to run this PR, I ran into this:

       error: hash mismatch in fixed-output derivation '/nix/store/c606r53i02yna84m5ds3q2mglzshd4pw-novnc-pve.drv':
         specified: sha256-BQm4hDC7b+YaFipVonzcwVG/4JswkMSFZEpVkCdfrjM=
            got:    sha256-5pybuOkvNVcP+In03ZokNpqgmGwB4DQEO4jmefV7W9Y=

Looks like this was recently taken care of in a different commit: b3f3158

@5aaee9 could this please be rebased off of current main? :)

EDIT: I have a fork that is based off latest main with this commit until this gets resolved for anyone who wants to use in the meantime: https://github.com/heywoodlh/proxmox-nixos/

@5aaee9
Copy link
Contributor Author

5aaee9 commented Nov 19, 2024

@heywoodlh Rebased with main

@JulienMalka
Copy link
Member

I don't like how hacky this is, but given that proxmox has not yet updated their edk2 mirror and this breaks our repo, will merge this until a better solution is found.

Thanks @5aaee9, @codgician :)

@JulienMalka JulienMalka merged commit 3e943de into SaumonNet:main Nov 19, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants