Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Classic snippets #275

Merged
merged 6 commits into from
Nov 22, 2018
Merged

Classic snippets #275

merged 6 commits into from
Nov 22, 2018

Conversation

jmisur
Copy link
Contributor

@jmisur jmisur commented Nov 11, 2018

Fixes #248
Also improves SARD/SRD mix example.

Copy link
Contributor

@fbenz fbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look code except for the removal of the system-dependent line separator. There is also one failing test:

[ERROR] Failures: 
[ERROR]   SectionSnippetTest.allClassicSnippets 
Expected: is "[[resources-allClassicSnippets]]\n=== Get Item By Id\n\ninclude::auto-method-path.adoc[]\n\ninclude::auto-description.adoc[]\n\n==== Example request\n\ninclude::curl-request.adoc[]\n\n==== Example request\n\ninclude::http-request.adoc[]\n\n==== Example response\n\ninclude::http-response.adoc[]\n\n==== Example request\n\ninclude::httpie-request.adoc[]\n\n==== Path parameters\n\ninclude::path-parameters.adoc[]\n\n==== Query parameters\n\ninclude::request-parameters.adoc[]\n\n==== Request fields\n\ninclude::request-fields.adoc[]\n\n==== Response fields\n\ninclude::response-fields.adoc[]\n\n==== Request Body\n\ninclude::request-body.adoc[]\n\n==== Response Body\n\ninclude::response-body.adoc[]\n\n==== Request headers\n\ninclude::request-headers.adoc[]\n\n==== Response headers\n\ninclude::response-headers.adoc[]\n\n==== Request Parts\n\ninclude::request-parts.adoc[]\n\n==== Response Parts\n\ninclude::response-parts.adoc[]\n\n==== Request Part Fields\n\ninclude::request-part-fields.adoc[]\n\n==== Hypermedia links\n\ninclude::links.adoc[]\n"
     but: was "[[resources-allClassicSnippets]]\n=== Get Item By Id\n\ninclude::auto-method-path.adoc[]\n\ninclude::auto-description.adoc[]\n\n==== Example request\n\ninclude::curl-request.adoc[]\n\n==== Example request\n\ninclude::http-request.adoc[]\n\n==== Example response\n\ninclude::http-response.adoc[]\n\n==== Example request\n\ninclude::httpie-request.adoc[]\n\n==== Path parameters\n\ninclude::path-parameters.adoc[]\n\n==== Query parameters\n\ninclude::request-parameters.adoc[]\n\n==== Request fields\n\ninclude::request-fields.adoc[]\n\n==== Response fields\n\ninclude::response-fields.adoc[]\n\n==== Request Body\n\ninclude::request-body.adoc[]\n\n==== Response Body\n\ninclude::response-body.adoc[]\n\n==== Request headers\n\ninclude::request-headers.adoc[]\n\n==== Response headers\n\ninclude::response-headers.adoc[]\n\n==== Request Parts\n\ninclude::request-parts.adoc[]\n\n==== Request Part Fields\n\ninclude::request-part-fields.adoc[]\n\n==== Hypermedia links\n\ninclude::links.adoc[]\n"

@@ -56,7 +57,6 @@

public class JacksonResponseFieldSnippetTest extends AbstractSnippetTests {

private static final String LINE_SEPERATOR = System.lineSeparator();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you intentionally removing the system-dependent LINE_SEPERATOR? I would suggest to keep it and move to a single LINE_SEPERATOR constant instead of having several ones across the tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced this ugly looking constant with fixLineSeparator() used in tests.

@jmisur
Copy link
Contributor Author

jmisur commented Nov 20, 2018

@fbenz ready

@jmisur jmisur merged commit fdc302f into master Nov 22, 2018
@jmisur jmisur deleted the classic_snippets branch November 22, 2018 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants