This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
Better support for ModelAttribute #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbenz
reviewed
Jan 27, 2020
...stdocs-core/src/main/java/capital/scalable/restdocs/payload/AbstractJacksonFieldSnippet.java
Outdated
Show resolved
Hide resolved
spring-auto-restdocs-core/src/main/java/capital/scalable/restdocs/util/HandlerMethodUtil.java
Outdated
Show resolved
Hide resolved
spring-auto-restdocs-core/src/main/java/capital/scalable/restdocs/util/HandlerMethodUtil.java
Outdated
Show resolved
Hide resolved
...tdocs-core/src/main/java/capital/scalable/restdocs/payload/JacksonModelAttributeSnippet.java
Outdated
Show resolved
Hide resolved
fbenz
approved these changes
Jan 28, 2020
|
It seems this logic is incorrect. For example, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #355
ModelAttribute is an optional annotation. By default, any argument that is not a simple value type (as determined by BeanUtils#isSimpleProperty) and is not resolved by any other argument resolver is treated as if it were annotated with @ModelAttribute.
This pull request fixes also section header. If operation is annotated with RequestMethod GET, section header is "query parameter".