feature: subscriptions api #85
Conversation
…eap/amazon-mws-api-sdk into feature/subscriptions-api
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 99.61% 99.65% +0.04%
==========================================
Files 18 19 +1
Lines 785 880 +95
Branches 54 56 +2
==========================================
+ Hits 782 877 +95
Misses 2 2
Partials 1 1
Continue to review full report at Codecov.
|
|
@moltar I messed up, was looking to request a review but accidentally merged it to master instead, reverted it using the revert option. I'll revert the revert when you approve this PR |
| | (number | string)[] | ||
| | object[] | ||
| | boolean | ||
| | { [key: string]: ParameterTypes } |
There was a problem hiding this comment.
Better expressed as Record<string, ParameterTypes>
There was a problem hiding this comment.
I tried that at first, but it threw Type alias 'ParameterTypes' circularly references itself. and only used the above as a fix. Any reason why { [key: string]: ParameterTypes } won't work?
This is where I got the "fix" microsoft/TypeScript#14174. I didn't read through everything though so there may be something I missed in that issue that might've been a better fix
| 'AttributeList.member': [ | ||
| { | ||
| Key: 'sqsQueueUrl', | ||
| // eslint-disable-next-line sonarjs/no-duplicate-string |
There was a problem hiding this comment.
Let's not disable this linting rule, but instead put the value in a constant at the top of the file or relevant describe code block.
There was a problem hiding this comment.
Ohh you're right. I missed this, I used a quick fix with the intention of fixing it after making sure that my tests passed but forgot to go back to it
|
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.