Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compile #382

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update compile #382

wants to merge 2 commits into from

Conversation

docteuri
Copy link

@docteuri docteuri commented Dec 6, 2023

Update compile, in order to build a custom servers.conf.erb file installed in the project directory.
It allow the user to add a pass parameter like
"nginx-http-includes": ["conf/servers.conf"],
And it allows the user to put a servers.conf.erb file in the conf folder in order to compile the listen variable : <%= ENV['PORT'] %>

Update compile, in order to build a custom servers.conf.erb file installed in the project directory.
@Frzk
Copy link
Contributor

Frzk commented Dec 7, 2023

Hello @docteuri,

First, thanks a lot for your PR and effort.

In this case, we think it would be better for you to rely on a multi-buildpack (https://doc.scalingo.com/platform/deployment/buildpacks/multi) with a .buildpacks file containing the following lines:

https://github.com/Scalingo/php-buildpack.git
https://github.com/Scalingo/nginx-buildpack.git

This would allow you to do what you want (and more). See our documentation for further details about the Nginx buildpack: https://doc.scalingo.com/platform/deployment/buildpacks/nginx

The PHP buildpack embeds a few things (like a basic Nginx setup) for convenience, but we can't put too much logic in here. That would duplicate the effort and be redundant with the Nginx buildpack.

I hope you understand :)
I'll let this issue opened a few days so you can answer/comment if need be.

Thanks again!

@docteuri
Copy link
Author

docteuri commented Dec 8, 2023

Bonjour.
Je suis d'accord qu'en théorie ça doit fonctionner. Mais quand je fais comme vous dites, j'ai un message :
cp /tmp/buildpackED5yz/bin/../config/nginx.conf.erb /build/54839f53-82ea-4530-a31c-9f63482593be/base_nginx.conf.erb

  • mv /app/vendor/nginx /build/54839f53-82ea-4530-a31c-9f63482593be/vendor
    mv: cannot move '/app/vendor/nginx' to '/build/54839f53-82ea-4530-a31c-9f63482593be/vendor/nginx': Directory not empty
    Le compile fait sont capricieux
    J'ai donné un accède opérateur.
    https://dashboard.scalingo.com/apps/osc-fr1/app-thuasne
    Merci de votre aide

@docteuri
Copy link
Author

docteuri commented Dec 8, 2023

ça ne fonctionne pas. Il faudrait corriger le compile de nginx pour qu'il s'impose lors du copy si le dossier est déjà rempli.

@Frzk
Copy link
Contributor

Frzk commented Dec 13, 2023

Bonjour,
En effet, il y a apparemment une incompatibilité entre les 2 buildpacks.
Votre patch est encore en discussion en interne chez nous. Je vous propose donc d'utiliser votre fork pour le moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants