SCALRCORE-22986 Provider > Non-empty plan with empty hooks for workspace #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DayS1eeper
commented
Sep 29, 2022
| @@ -484,6 +485,14 @@ func resourceScalrWorkspaceRead(d *schema.ResourceData, meta interface{}) error | |||
| "pre_apply": workspace.Hooks.PreApply, | |||
| "post_apply": workspace.Hooks.PostApply, | |||
| }) | |||
| } else if _, ok := d.GetOk("hooks"); ok { | |||
There was a problem hiding this comment.
Also, I thought about fixing this problem by setting a default value for hook argument, but it is not supported for TypeList hashicorp/terraform-plugin-sdk#142
petroprotsakh
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Documentation
State