Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supervisor config in getting started guide #338

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

amclain
Copy link
Member

@amclain amclain commented Oct 23, 2023

Description

Update the example code in the getting started guide for starting Scenic in a supervision tree.

Motivation and Context

When I used the code in the getting started guide for a recent project, the example code no longer worked.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature
    but make things better)

Checklist

  • Check other PRs and make sure that the changes are not done yet.

@amclain amclain self-assigned this Oct 23, 2023
Copy link
Collaborator

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice!

@axelson axelson merged commit 0cdf1bd into ScenicFramework:main Oct 30, 2023
3 checks passed
@amclain amclain deleted the update-supervisor-config branch October 30, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants