Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow start error to properly propagate #339

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Allow start error to properly propagate #339

merged 1 commit into from
Dec 7, 2023

Conversation

seb3s
Copy link
Contributor

@seb3s seb3s commented Nov 17, 2023 •
edited
Loading

for the caller to take the appropriate action

Description

The already_started error is not properly propagated as it was before version 0.11
This fixes it

@seb3s seb3s changed the title allow a start error to properly propagate for the caller to take the … allow a start error to properly propagate Nov 24, 2023
crertel
crertel approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@crertel crertel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative okay, but doesn't this change the signature of the return value from :ok to {:ok, <pid>} ?

Nevermind, reading it hard, looks good!

@crertel crertel merged commit d3f1e6b into ScenicFramework:main Dec 7, 2023
4 of 5 checks passed
@crertel crertel changed the title allow a start error to properly propagate Allow start error to properly propagate Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amclain amclain amclain approved these changes

@crertel crertel crertel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seb3s @crertel @amclain