Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to ruff external schema #2724

Closed

Conversation

JonathanPlasse
Copy link
Contributor

Hi,
In compliance with the single source of truth policy, this updates the ruff schema point to the external schema from the official repository.

Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong review outcome.

Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mandatory fixes found, changes requested.
Thanks for a contribution! 🚀

},
"title": "Options",
"type": "object"
"$ref": "https://raw.githubusercontent.com/charliermarsh/ruff/main/ruff.schema.json"
Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mandatory fix: broken url (error source: catalog.json): "url": "https://raw.githubusercontent.com/charliermarsh/ruff/main/ruff.schema.json" expected for ruff entry.
Note: check how it's done for markdownlint, I guess the root of the problem is here.

@charliermarsh
Copy link
Contributor

I'd prefer not to change this. Copying over my comment from the Ruff issue (astral-sh/ruff#1765):

Unfortunately, the Schema Store doesn't support URLs for embedded schemas. So we can't point it to a URL if we want the schema to appear for pyproject.toml files. I initially implemented it as a URL (#2673), then intentionally changed it to bundle in the repo to support pyproject.toml files (#2683). It's an unfortunate limitation, but for now we have to update it periodically.

@not-my-profile
Copy link

Unfortunately, the Schema Store doesn't support URLs for embedded schemas.

Is there some tracking issue for that limitation?

@charliermarsh
Copy link
Contributor

Not sure, but here's the relevant section in the docs. (Tests will also fail if you try to use an external schema.)

@JonathanPlasse JonathanPlasse deleted the ruff-external-schema branch January 10, 2023 18:15
@not-my-profile
Copy link

I just filed #2731 for this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants