-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point to ruff external schema #2724
Point to ruff external schema #2724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong review outcome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mandatory fixes found, changes requested.
Thanks for a contribution! 🚀
}, | ||
"title": "Options", | ||
"type": "object" | ||
"$ref": "https://raw.githubusercontent.com/charliermarsh/ruff/main/ruff.schema.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mandatory fix: broken url (error source: catalog.json): "url": "https://raw.githubusercontent.com/charliermarsh/ruff/main/ruff.schema.json"
expected for ruff
entry.
Note: check how it's done for markdownlint
, I guess the root of the problem is here.
I'd prefer not to change this. Copying over my comment from the Ruff issue (astral-sh/ruff#1765):
|
Is there some tracking issue for that limitation? |
Not sure, but here's the relevant section in the docs. (Tests will also fail if you try to use an external schema.) |
I just filed #2731 for this :) |
Hi,
In compliance with the single source of truth policy, this updates the ruff schema point to the external schema from the official repository.