-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pyproject.json #2782
Update pyproject.json #2782
Conversation
The build failed. Also, please remove the ruff schema from the SchemaStore repo, if it's no longer the authoritative source. |
Converting this to a draft until I can figure out why the build's failing. |
The validator is having issues with resolving external schemas not located on the |
I think schemas that are referenced by others schemas have to be included locally and not via external references. That's why we moved away from using an external reference for Ruff in the first place (it was initially linked via URL, but that doesn't work with |
@voidei Resolving external schemas is not possible right now (see #2731 for a tracking issue) As @charliermarsh mentioned, you would have to include the schema locally. It's something I want to fix eventually, but I can't say when |
for more information, see https://pre-commit.ci
@hyperupcall Hmm, I see 🤔 Updated the local schema to be consistent with the remote one, is there any way we would be able to update the local one whenever @charliermarsh updates it on their end? |
Unfortunately not at the moment, although that is a good idea. |
@hyperupcall - I'm happy to get into the habit of PRing an update on each release (assuming the schema changed), but that'd be about one update per week, so would want to check first to see if that would feel overbearing or spammy. |
It's definitely fine by me, although I'm not an official maintainer merging the PR's - @madskristensen and @GerryFerdinandus are. I can't speak for them, but I don't think once a week sounds too spammy or whatater. |
Thanks |
* Update local ruff schema file * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
The ruff schema on the schemastore is outdated.