Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.json #2782

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Update pyproject.json #2782

merged 2 commits into from
Apr 3, 2023

Conversation

voidei
Copy link
Contributor

@voidei voidei commented Feb 9, 2023

The ruff schema on the schemastore is outdated.

@madskristensen
Copy link
Contributor

The build failed. Also, please remove the ruff schema from the SchemaStore repo, if it's no longer the authoritative source.

@voidei voidei marked this pull request as draft February 9, 2023 23:46
@voidei
Copy link
Contributor Author

voidei commented Feb 9, 2023

Converting this to a draft until I can figure out why the build's failing.

@voidei
Copy link
Contributor Author

voidei commented Feb 10, 2023

The validator is having issues with resolving external schemas not located on the schemastore.org domain when referenced from within a schema located on the domain. I did some combing through the other schemas and can't find any that externally refer to any schemas located externally. Would the answer to this be to have it refer to a schema empty bar $ref key that links to the ruff schema, similarly to how the markdownlint schema is handled? It's a relatively difficult thing to test locally as the actual schemastore schema for ruff.json is still there.

@charliermarsh
Copy link
Contributor

I think schemas that are referenced by others schemas have to be included locally and not via external references. That's why we moved away from using an external reference for Ruff in the first place (it was initially linked via URL, but that doesn't work with pyproject.toml).

@hyperupcall
Copy link
Member

@voidei Resolving external schemas is not possible right now (see #2731 for a tracking issue)

As @charliermarsh mentioned, you would have to include the schema locally.

It's something I want to fix eventually, but I can't say when

@voidei
Copy link
Contributor Author

voidei commented Apr 1, 2023

@hyperupcall Hmm, I see 🤔 Updated the local schema to be consistent with the remote one, is there any way we would be able to update the local one whenever @charliermarsh updates it on their end?

@voidei voidei marked this pull request as ready for review April 1, 2023 00:52
@hyperupcall
Copy link
Member

Unfortunately not at the moment, although that is a good idea.

@charliermarsh
Copy link
Contributor

@hyperupcall - I'm happy to get into the habit of PRing an update on each release (assuming the schema changed), but that'd be about one update per week, so would want to check first to see if that would feel overbearing or spammy.

@hyperupcall
Copy link
Member

It's definitely fine by me, although I'm not an official maintainer merging the PR's - @madskristensen and @GerryFerdinandus are.

I can't speak for them, but I don't think once a week sounds too spammy or whatater.

@madskristensen madskristensen merged commit a6dc92e into SchemaStore:master Apr 3, 2023
@madskristensen
Copy link
Contributor

Thanks

jmatias pushed a commit to jmatias/schemastore that referenced this pull request Jul 19, 2023
* Update local ruff schema file

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants