Removed Umbraco CMS settings from appsettings.json #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may be worth re-addresing this when #2731 is fixed. Agree that it's preferrable to have no schema versus incorrect (and not updated) schema. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Umbraco issue 14131, the current Umbraco CMS settings schema in appsettings.json is incorrect for some properties and this is conflicting with the schema that is being shipped with the CMS. Considering that Umbraco is including their own (CMS version dependent) schema , it does not make sense to have the Umbraco CMS settings in the schemastore.
This PR removes the Umbraco CMS settings from appsettings.json schema.