Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amx-muse): add initial schema file #4319

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

damienbutt
Copy link

Hello,

I would like to contribute this schema to the store. Hopefully everything is OK.

I followed the guidelines and ran the tests.

Thanks,
D

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall
Copy link
Member

Thanks! Looks good to me, but I think the fileMatch is a bit too generic to accept. I'll be able to merge this if the fileMatch is empty, or changed to something that won't potentially overlap with a different service or application

@damienbutt
Copy link
Author

damienbutt commented Dec 31, 2024

So the file name that is specified by the manufacturer (AMX) is program.json. It has to be this as once the program files are loaded onto their controller hardware, it looks for that file specifically to kick things off.

What would the consequence of making the fileMatch empty be? Isn't that property crucial to how IDE's associate schemas to files?

Is there any way to work around this?

Thanks,
D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants