Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow external package mappings in imports field in package.json #4340

Conversation

sapphi-red
Copy link
Contributor

It is allowed to write package names in imports field mappings like:

{
  "imports": {
    "#foo": "different-package"
  }
}

But this was not allowed by the schema (only strings with ./ prefix was allowed).

This PR fixes that.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@madskristensen madskristensen merged commit 1beaa9f into SchemaStore:master Jan 9, 2025
4 checks passed
@madskristensen
Copy link
Contributor

Thanks

@sapphi-red sapphi-red deleted the fix/allow-imports-field-to-conatin-mappings-to-external-packages branch January 10, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants