Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Element Web's logo with SchildiChat logo on the error page #7

Closed
wants to merge 1 commit into from

Conversation

luixxiul
Copy link

@luixxiul luixxiul commented Dec 1, 2024

Before After
before after

I'm not sure what is the best way of changing the string Element with regard to localization, so I let it as it is.


  • I agree to release my changes under this project's license

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul luixxiul marked this pull request as ready for review December 1, 2024 08:19
@SpiritCroc
Copy link
Member

Thanks for finding. For logos we generate automated commits, so it's better to not commit manually but rather add something to icon_gen.sh that overwrites the Element icon. If you want, you can PR a change to add this icon to the script, or I can do it too, as you prefer.

For localization of "Element" strings I haven't decided on an approach yet, probably makes sense if I port over correct_strings.sh from old SchildiChat Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants