Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress bar to install command #1028

Merged
merged 8 commits into from
May 25, 2024
Merged

Add progress bar to install command #1028

merged 8 commits into from
May 25, 2024

Commits on Aug 19, 2023

  1. Add progress bar to install command

    @eblocha
    eblocha committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    a7fe780 View commit details
    Browse the repository at this point in the history

  2. Create progress bar using with_template to avoid double-parsing

    @eblocha
    eblocha committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    9ae6a36 View commit details
    Browse the repository at this point in the history

  3. Only show progress bar when log level is info or above

    @eblocha
    eblocha committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    0298a47 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. Add semicolon for clippy

    @eblocha
    eblocha committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    d0695be View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Use impl notation for extract_archive_into for readability

    @eblocha
    eblocha committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    22d2dd9 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Add unit test for the progress bar. 

    Ensures data is still read from the request. indicatif does not expose their
Term struct, so it is difficult to mock a terminal to verify the progress
bar looks correct.
    @eblocha
    eblocha committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    eb36bd3 View commit details
    Browse the repository at this point in the history

  2. Add a mocked terminal that writes to a shared buffer to test the prog… 

    …ress bar
    @eblocha
    eblocha committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    22d7645 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Merge branch 'master' into progress-bar

    @Schniz
    Schniz authored May 25, 2024
    Configuration menu
    Copy the full SHA
    065ff49 View commit details
    Browse the repository at this point in the history