Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support x64-musl #1109

Merged
merged 3 commits into from
May 24, 2024
Merged

fix: support x64-musl #1109

merged 3 commits into from
May 24, 2024

Conversation

Vinfall
Copy link
Contributor

@Vinfall Vinfall commented Apr 11, 2024

Yes, an easy fix as silly as bypassing the hardcoded check and then set FNM_NODE_DIST_MIRROR & FNM_ARCH in shell rc.

Yes, an easy fix as silly as bypassing the hardcoded check and then set `FNM_NODE_DIST_MIRROR` & `FNM_ARCH` in shell rc.
Copy link

changeset-bot bot commented Apr 11, 2024

🦋 Changeset detected

Latest commit: ba7008e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fnm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fnm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 5:24am

@Vinfall
Copy link
Contributor Author

Vinfall commented Apr 11, 2024

I think it's also possible to support other musl architectures, if the unofficial node mirror has builds for those. But I'm lazy enough to pretend they do not exist. nvm, unofficial node mirror only has x64-musl tarballs.

@Schniz Schniz merged commit 8f3acbb into Schniz:master May 24, 2024
12 of 13 checks passed
@github-actions github-actions bot mentioned this pull request May 24, 2024
@Vinfall Vinfall deleted the musl-support branch May 25, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants