-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows arm64 release binaries #1250
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 07b9e43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Successful CI run in my fork (given that the CI in this PR is pending maintainer approval): https://github.com/dennisameling/fnm/actions/runs/10829319005/job/30046612481?pr=1 This basically doubles the build time for the "Release build for Windows" job, because the builds run sequentially. Alternatively, I could change the CI config in such way that both builds (x64 and arm64) run in parallel. WDYT @Schniz? The output of
|
@dennisameling will it download the correct Windows version off Node.js dist? |
@Schniz it will indeed! The only caveat is that official Windows arm64 support was added in Node 20 (see e.g. here). Windows arm64 supports x64 emulation, so folks needing older versions can always do something like I don't think Here's some examples using the
|
May also need to modify install.sh, and perhaps add binstall support at the same time If use these two names, you can skip the compilation using cargo binstall
|
310cdc7
to
dd6d17d
Compare
This can potentially be superseded by #1282 |
Closes #1068
Even though the GitHub Runner hosts are x64, MSVC and Rust support cross-compiling to arm64 perfectly fine on Windows. This PR uploads arm64 artifacts for
fnm
.