Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#258) - certification module refactor #259

Merged
merged 12 commits into from
Aug 13, 2024

Conversation

audgns10
Copy link
Member

๐Ÿ’ก ๊ฐœ์š”

  • Certification ๋ชจ๋“ˆ์ด ๋ฆฌํŒฉํ† ๋ง์ด ํ•„์š”ํ•ฉ๋‹ˆ๋‹ค

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • Certification ๋ชจ๋“ˆ์„ ๋ฆฌํŒฉํ† ๋ง ํ–ˆ์Šต๋‹ˆ๋‹ค
    • ์ปดํ‘œ์ €๋ธ” ์•ˆ์—์„œ remember๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ์ƒํƒœ๋ฅผ ๊ด€๋ฆฌํ•˜๋Š” ๊ฒƒ์„ viewModel์—์„œ SavedStateHandle๋กœ ๊ด€๋ฆฌํ•  ์ˆ˜ ์žˆ๋„๋ก ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค
    • ์ƒํƒœ ํ˜ธ์ด์ŠคํŒ…์„ ์‚ฌ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค
    • ๊ตฌ์กฐ ๋ถ„ํ•ด ์„ ์–ธ์„ ์‚ฌ์šฉํ•ด์„œ remember๋ฅผ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค
    • ์žฌ์‚ฌ์šฉ ๊ฐ€๋Šฅ์„ฑ์ด ์žˆ๋Š” ๋ฌธ์ž๋ฅผ strings.xml ํŒŒ์ผ์— ๋„ฃ์–ด stringResource๋กœ ์ฝ์–ด์˜ฌ ์ˆ˜ ์žˆ๋„๋ก ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค

๐Ÿ”€ ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • refactor CertificationViewModel
  • refactor AddCertificationScreen
  • refactor CertificationScreen

@audgns10 audgns10 merged commit 9bf43cc into develop Aug 13, 2024
1 check passed
@audgns10 audgns10 deleted the refactor/258-certification-module-refactor branch August 13, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2๏ธโƒฃ Priority: Medium ์šฐ์„ ์ˆœ์œ„ - ์ค‘ โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
4 participants