Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(engine): replace dotembed with all flag #260

Merged
merged 1 commit into from
Mar 31, 2023
Merged

refactor(engine): replace dotembed with all flag #260

merged 1 commit into from
Mar 31, 2023

Conversation

brumhard
Copy link
Contributor

This PR replaces the whole dotembed generator magic with the new all flag of go embed.
This is documented here: https://pkg.go.dev/embed.

@github-advanced-security
Copy link

You have successfully added a new Semgrep configuration .github/workflows/semgrep.yml:semgrep. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@danielzwink danielzwink merged commit 7a96e1b into main Mar 31, 2023
@danielzwink danielzwink deleted the feature/replace-dotembed branch March 31, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielzwink danielzwink danielzwink approved these changes

@linuxluigi linuxluigi Awaiting requested review from linuxluigi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brumhard @danielzwink