-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add goreleaser for gt cli #44
Conversation
fc803af
to
b85e202
Compare
Hi @dirien ty for the PR. I'll look into it on friday. |
Or we do a release commit for every version to set the correct version in the file to make sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Would be great if you could just add a small note to the readme installation instructions that binary installation is also possible.
Would also be great if we could add other targets like brew in a next step but I really like this as a first step 🙂
Oh and would be great if we could finish the discussion around embedding vs setting the version through -X before merging. |
b85e202
to
9dc00d7
Compare
@brumhard: Added the install notes for the intstalltion of the binaries. The question with the version: I did not understand 😅. In goreleaser you can pass the version being released to the LDFLAGS -x. As you saw from the PR, i did not touched this area, and the version will still be collected from the txt file. |
Ty 🙏 |
@brumhard, ofc i can drop them from the PR. Just let me know, and I remove the two -X from the goreleaser and delete the variables from the |
@dirien alright then lets keep them out of the PR for now and we can still add them later if we feel the need for it 👍 |
Signed-off-by: Engin Diri <engin.diri@mail.schwarz>
9dc00d7
to
2f6fbbd
Compare
@brumhard done and gone :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the great contribution 🙂 now we can show off our mad goreleaser skills in the meeting with Carlos 😄
@brumhard, Thanks! if you plan to create a release let me know so I can be around. THE GITHUB_TOKEN should automatically set. But you never know 😄 |
Signed-off-by: Engin Diri engin.diri@mail.schwarz
fixes #45
As discussed in #43 the PR for gt itself.