Skip to content
This repository has been archived by the owner on Jan 27, 2020. It is now read-only.

Rewrote docker containers using bioconda environment.yml ? #551

Closed
maxulysse opened this issue Mar 20, 2018 · 8 comments
Closed

Rewrote docker containers using bioconda environment.yml ? #551

maxulysse opened this issue Mar 20, 2018 · 8 comments

Comments

@maxulysse
Copy link
Member

cf SciLifeLab/NGI-RNAseq#216

@maxulysse
Copy link
Member Author

maxulysse commented Mar 26, 2018

Tried to update our most complicated container (the one with the most tools: sarek) using this method.
First the pros:

  • I like the simplicity of the method.
  • No need to tailor the installation for each tools.

But the miniconda base image (234 MB) is quite larger than the base debian:8 image (53 MB).
So the resulting image is obviously larger (470 MB) than what we have (245 MB).

What do you think?

@maxulysse maxulysse changed the title Rewrote docker containers using bioconda environment.yml Rewrote docker containers using bioconda environment.yml ? Mar 26, 2018
@apeltzer
Copy link
Collaborator

Personally, I'd say this is an improvement, as its much simpler and relies on packages that aare ultimately tested by everyone in the bioconda community, which should in general be more reproducible and reliable. I see your point with 200+MB more for the image, but wouldn't see this as the biggest issue here - its not 1GB+ and most people won't really care about 200MB more to download.

@marcelm
Copy link
Member

marcelm commented Mar 26, 2018

You may be able to reduce the size somewhat by putting an && conda clean -a after the RUN conda install ...

@maxulysse
Copy link
Member Author

Good point, I'll try that ;-)

@maxulysse
Copy link
Member Author

@apeltzer
My concern is not the fact that it is 200+MB but more that it is almost twice the amount.
But regarding that I have other containers that are much more bigger on a higher order of magnitude, I can work with that.

@maxulysse
Copy link
Member Author

@marcelm tried it, and it's now 387 MB so almost 100 MB down, which I can accept given the simplicity it will give us in installing all the tools.

@ewels
Copy link
Member

ewels commented Mar 27, 2018

For what it's worth, I've ported the MethylSeq and RNA pipelines to this method now and I'm totally in love with it 😄 Especially with the cool nf-core lint . command which warns you if there are newer versions of any packages available...

@maxulysse
Copy link
Member Author

closed by #607

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants